[PATCH] D16440: [ThinLTO] Link in only necessary DICompileUnit operands

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/Linker/IRMover.cpp:1309
@@ +1308,3 @@
+        // non-metadata operands.
+        auto *NewCU = DICompileUnit::getDistinct(
+            CU->getContext(), CU->getSourceLanguage(), NewFile, nullptr,
----------------
aprantl wrote:
> Why not use a DIBuilder for this?
I looked at DIBuilder last night and it wasn't clear to me how to use that in this context where I need to call MapMetadata to map in the transitively referenced MD from source to dest.

================
Comment at: lib/Linker/IRMover.cpp:1311
@@ +1310,3 @@
+            CU->getContext(), CU->getSourceLanguage(), NewFile, nullptr,
+            CU->isOptimized(), nullptr, CU->getRuntimeVersion(), nullptr,
+            CU->getEmissionKind(), nullptr, nullptr, NewSubprograms, nullptr,
----------------
Ok, will map those MDString fields in as well.


http://reviews.llvm.org/D16440