[PATCH] D16440: [ThinLTO] Link in only necessary DICompileUnit operands

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 09:25:47 PST 2016


aprantl added inline comments.

================
Comment at: lib/Linker/IRMover.cpp:1311
@@ +1310,3 @@
+            CU->getContext(), CU->getSourceLanguage(), NewFile, nullptr,
+            CU->isOptimized(), nullptr, CU->getRuntimeVersion(), nullptr,
+            CU->getEmissionKind(), nullptr, nullptr, NewSubprograms, nullptr,
----------------
We also need to preserve the splitDebugName. When module debugging is enabled there will be several additional skeleton compile units without any children in the module that point to the (clang) modules that contain shared debug type information which may be referenced by types that hang off the imported function.

I also don't see a reason to drop the string fields like flags and producer.


http://reviews.llvm.org/D16440





More information about the llvm-commits mailing list