[PATCH] D16440: [ThinLTO] Link in only necessary DICompileUnit operands

[David Blaikie via llvm-commits]

dblaikie added a subscriber: dblaikie.
dblaikie added a comment.

Should the tests be testing that, when you import the DISubprogram, that you get any types needed by that DISubprogram (& only those types)?


================
Comment at: test/Transforms/FunctionImport/funcimport_debug.ll:17
@@ -16,2 +16,3 @@
 ; CHECK: ![[MAINSP]] = distinct !DISubprogram(name: "main"
+; CHECK-NOT: distinct !DICompileUnit({{.*}} enums:
 ; CHECK: !{{[0-9]+}} = distinct !DICompileUnit({{.*}} subprograms: ![[SPs2:[0-9]+]]
----------------
Does this test the right thing? (if you revert your change and run this test, does it fail?)

I would've expected the following DICompileUnit to match, and there to be no DICompileUnit match between one and the next. Whereas I would've guessed this was trying to check that there were no enums in the DICompileUNit checked on the next line?


http://reviews.llvm.org/D16440