[lld] r258499 - Use of llvm_unreachable instead of warning in EhFrameHeader<ELFT>::assignEhFrame().

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 08:27:13 PST 2016


>This should probably be written with an assert instead:

>
> assert((!this->Sec || this->Sec == Sec) && "multiple .eh_frame sections ....");

This should never happen, and if will due to a bug or something then result is completely unknown, because
code does not suppose that. So it is fatal error actually.
That why I think unreachable fits better than assert and also there is no asserts in release usually.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160122/bc951e5c/attachment.html>


More information about the llvm-commits mailing list