[PATCH] D16213: [MD] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

This LGTM but I'd appreciate it if someone else LGTM'd it too.

You'll need to make corresponding changes to the other projects (e.g. clang) to avoid buildbot failures.


================
Comment at: tools/dsymutil/DwarfLinker.cpp:599
@@ -598,2 +598,3 @@
 
-  MAB = TheTarget->createMCAsmBackend(*MRI, TripleName, "");
+  MCTargetOptions Options;
+  MAB = TheTarget->createMCAsmBackend(*MRI, TripleName, "", Options);
----------------
Does it matter that we don't initialize the ABI name here? I don't think it does but I thought I ought to double check.

================
Comment at: tools/llvm-dwp/llvm-dwp.cpp:385-386
@@ -384,3 +384,4 @@
 
-  auto MAB = TheTarget->createMCAsmBackend(*MRI, TripleName, "");
+  MCTargetOptions Options;
+  auto MAB = TheTarget->createMCAsmBackend(*MRI, TripleName, "", Options);
   if (!MAB)
----------------
Does it matter that we don't initialize the ABI name here? I don't think it does but I thought I ought to double check.


http://reviews.llvm.org/D16213