[PATCH] D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings.

Yury Gribov via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 02:53:31 PST 2016


ygribov added a comment.

> > >   $ PATH=$(pwd)/bin:$PATH python -m unittest -v

> 

> > 

> 

> > 

> 

> > 

> 

> > 

> 

> >   I don't think so:

> 

> 

> the command i gave to you works fine on my environment.

>  would be curious to know what OS/python do you use to have the differences.


I'm on Ubuntu 14.04 with it's Python 2.7.6 (default, Jun 22 2015, 17:58:13).

> anyway, to run python unittest see more on this link https://docs.python.org/2/library/unittest.html


Ah, thanks, it works now but only if I ran it as

  $ python -m unittest  tests.__init__

and add

  unittest.TextTestRunner(verbosity=2).run(suite())

to tests/__init__.py (and this has 41 error).

> i would make this method do only the release flag filtering.


Got it.

> minor comments: you should extend the required decorator with force_analyze_debug_code on create_commands method...

>  please call the new_args as result which is more descriptive... please add documentation to this new method...


Right.


Repository:
  rL LLVM

http://reviews.llvm.org/D16200





More information about the llvm-commits mailing list