[PATCH] D16328: AMDGPU: Remove AMDIL.round.nearest intrinsic

Michel Dänzer via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 18:27:32 PST 2016


michel.daenzer added a comment.

In http://reviews.llvm.org/D16328#332364, @nhaehnle wrote:

> (And as an aside, I feel we should absolutely avoid changes to LLVM that break Mesa silently.


Of course.

> This current change is okay because it isn't silent: using old Mesa will crash and burn with a rather explicit message as soon as the removed intrinsic is encountered. But it's theoretically conceivable that some more subtle LLVM change around ABIs could cause incorrect rendering without an explicit message about it, and that would be bad.)


Old Mesa generally doesn't build against new LLVM, which is why that's not a supported combination.


http://reviews.llvm.org/D16328





More information about the llvm-commits mailing list