[PATCH] D16374: [sancov] generating html report on coverage dump

[Kostya Serebryany via llvm-commits]

kcc added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_common.cc:426
@@ -425,1 +425,3 @@
 char *FindPathToBinary(const char *name) {
+  if (FileExists(name)) {
+    return internal_strdup(name);
----------------
remove {}

================
Comment at: lib/sanitizer_common/sanitizer_common_nolibc.cc:27
@@ -26,1 +26,3 @@
 
+#if !SANITIZER_LINUX
+int StartSubprocess(const char *program, char *const argv[],
----------------
this is gross :) 
Put the stubs into windows and mac files instead

================
Comment at: lib/sanitizer_common/sanitizer_coverage_libcdep.cc:793
@@ +792,3 @@
+
+  InternalMmapVector<char *> sancov_argv(module_name_vec.size() + 2);
+  sancov_argv.push_back(FindPathToBinary(common_flags()->sancov));
----------------
you need InternalScopedString

================
Comment at: lib/sanitizer_common/sanitizer_coverage_libcdep.cc:830
@@ +829,3 @@
+
+  if (common_flags()->html_cov_report) {
+    sancov_argv.push_back(nullptr);
----------------
put this into a separate function


http://reviews.llvm.org/D16374