[PATCH] D16417: [opaque pointer types] [NFC] {Load, Store}Inst: get loaded/stored type from the instruction.

Eduard Burtescu via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 15:33:09 PST 2016


eddyb added inline comments.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:1991
@@ -1990,3 +1990,3 @@
   // Make sure that the pointer does not point to structs.
-  if (Ptr->getType()->getPointerElementType()->isAggregateType())
+  if (DataType && DataType->isAggregateType())
     return 0;
----------------
eddyb wrote:
> dblaikie wrote:
> > Do we need to support a null type parameter here?
> This might be an artifact of rebasing, i.e. it was needed but now it's not.
> I'll try testing without the `nullptr` default and this check.
Ah, that call site doesn't show up in the commit because it hasn't changed.
See the `collectLoopUniforms` method.


http://reviews.llvm.org/D16417





More information about the llvm-commits mailing list