[PATCH] D15784: Enable 2 warnings on MSVC, turn on StringPooling & intrinsic functions

[Alexander Riccio via llvm-commits]

ariccio marked an inline comment as done.
ariccio added a comment.

This updated diff should be compatible with old versions of CMake, if they don't know about Visual Studio 2015, they'll just define MSVC_VERSION to be a smaller number.

Testing this diff (to generate a solution) as we speak.


================
Comment at: C:/LLVM/llvm/cmake/modules/HandleLLVMOptions.cmake:366
@@ -365,1 +365,3 @@
 
+  if(MSVC14)
+    # Disable string literal const->non-const type conversion
----------------
aaron.ballman wrote:
> Is this supported in CMake 2.8.8 (that's our min required version of CMake currently)? Also, is this forwards compatible, or will it only enable strictStrings on MSVC 14 and not later versions? (I don't know CMake well enough to answer either of those questions.)
I don't know, and that's a nice catch on your part.

I //presume// it is not forward compatible. I'm also not sure how I'd enable strictStrings in a forwards compatible way.

Ideally, future versions of MSVC wouldn't need strictStrings for standards compliance, but I'm not sure if I'd be reasonable to make an assumption about MSVC.


http://reviews.llvm.org/D15784