[PATCH] D16424: [ThinLTO] Do metadata linking during batch function importing

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 14:17:26 PST 2016


joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:308
@@ +307,3 @@
+    // If modules were created with lazy metadata loading, materialize it
+    // now, before linking it (otherwise this will be a noop).
+    SrcModule->materializeMetadata();
----------------
Not at the same scale: my point is to materialize only the metatadata referenced by the function being materialized, so it is not the same as materializing *all* the metadata: if we import one function from a module we would be able to materialize only the needed metadata.


http://reviews.llvm.org/D16424





More information about the llvm-commits mailing list