[llvm] r258428 - [LibCallSimplifier] don't get fooled by a fake fmin()

[Davide Italiano via llvm-commits]

On Thu, Jan 21, 2016 at 3:19 PM, Sanjay Patel via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: spatel
> Date: Thu Jan 21 14:19:54 2016
> New Revision: 258428
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258428&view=rev
> Log:
> [LibCallSimplifier] don't get fooled by a fake fmin()
>
> This is similar to the bug/fix:
> https://llvm.org/bugs/show_bug.cgi?id=26211
> http://reviews.llvm.org/rL258325
>
> The fmin() test case reveals another bug caused by sloppy
> code duplication. It will crash without this patch because
> fp128 is a valid floating-point type, but we would think
> that we had matched a function that used doubles.
>
> The new helper function can be used to replace similar
> checks that are used in several other places in this file.
>

This is nice. When I first started looking at LibCallSimplifier I
noticed (and was disturbed) by all the duplicated checks, so I factored
out some of them.
Unfortunately there's still a lot more to do, so thanks for picking up
the slack. I think at some point we might sit down and discuss how to
refactor this properly.

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare