[PATCH] D16424: [ThinLTO] Do metadata linking during batch function importing

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 12:54:35 PST 2016


joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:308
@@ +307,3 @@
+    // The modules were created with lazy metadata loading. Materialize it
+    // now, before linking it.
+    SrcModule->materializeMetadata();
----------------
I'd question why did we load them with lazy metadata in the first place? If we have materialize the metadata anyway, we can as well load them up-front.


http://reviews.llvm.org/D16424





More information about the llvm-commits mailing list