[PATCH] D16000: Add "/dev/console" as a special file name to lit

[Yunzhong Gao via llvm-commits]

ygao added a comment.

> We should agree that we are fine with having a test in check-all that writes to

>  the console (or is the test-suite using lit these days?)


I am not familiar with test-suite and so would appreciate some opinion from an expert in this area regarding
the pros and cons of test-suite vs check-clang. I assume both are run regularly on buildbots.

Looking at the existing test files in test-suite, it seems that it uses cmake or makefile, but not lit.

Here's my concern for moving this test into test-suite: I do not see how to specify a command-line for only
one test. This particular test still needs to output to the console, but modifying the root makefile would risk
making all tests output to the console. On the other hand, I agree that having a test in check-all that writes to
the console does look ugly.


================
Comment at: utils/lit/lit/TestRunner.py:251
@@ -248,1 +250,3 @@
+                        # "CON:" is a special filename for the console.
+                        r[2] = open("CON:", r[1])
                     else:
----------------
aaron.ballman wrote:
> Why `CON:` instead of `CON`?
The trailing colon makes it look like a device, but there is no practical advantage in doing so. I'll remove the colon.


http://reviews.llvm.org/D16000