[llvm] r252563 - [PGO] Make indexed value profile data more compact

[Xinliang David Li via llvm-commits]

The setter call is invoked only in a unittest. Can you send me the
failure report? (currently InstrProfRecordTraits has no members and is
stateless).

thanks,

David

On Thu, Jan 21, 2016 at 1:17 AM, Vedant Kumar <vsk at apple.com> wrote:
> Hi David,
>
>> namespace {
>> +static support::endianness ValueProfDataEndianness = support::little;
>> +// Internal interface for testing purpose only.
>> +void InstrProfWriter::setValueProfDataEndianness(
>> +    support::endianness Endianness) {
>> +  ValueProfDataEndianness = Endianness;
>> +}
>
>
> Please remove this static variable. It breaks clients who use llvm in a multi-threaded environment.
>
> thanks
> vedant
>