[llvm] r255909 - [ThinLTO] Metadata linking for imported functions

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 08:51:02 PST 2016


Fixed in r258405.
Thanks,
Teresa

On Thu, Jan 21, 2016 at 6:54 AM, Teresa Johnson <tejohnson at google.com>
wrote:

> Thanks for pointing this out. I am going through the code now and will fix
> these places. There are some on the insert side that could be changed
> similarly to insert() rather than count() followed by assignement via
> operator[].
> Teresa
>
> On Wed, Jan 20, 2016 at 3:31 PM, Rafael EspĂ­ndola <
> rafael.espindola at gmail.com> wrote:
>
>> > +  if (MDValueToValIDMap.count(MD)) {
>> > +    unsigned Idx = MDValueToValIDMap[MD];
>>
>> Hi,
>>
>> There are many cases like this where we are doing more hash lookups
>> than needed. In this case you can use find and compare with end().
>>
>> Cheers,
>> Rafael
>>
>
>
>
> --
> Teresa Johnson |  Software Engineer |  tejohnson at google.com |
> 408-460-2413
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160121/b82cc3d0/attachment.html>


More information about the llvm-commits mailing list