[PATCH] D16328: AMDGPU: Remove AMDIL.round.nearest intrinsic

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 08:13:52 PST 2016


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

I don't think we publish "known working combinations" anywhere, and I do believe we should at least document it - thanks for that!

(And as an aside, I feel we should absolutely avoid changes to LLVM that break Mesa silently. This current change is okay because it isn't silent: using old Mesa will crash and burn with a rather explicit message as soon as the removed intrinsic is encountered. But it's theoretically conceivable that some more subtle LLVM change around ABIs could cause incorrect rendering without an explicit message about it, and that would be bad.)


http://reviews.llvm.org/D16328





More information about the llvm-commits mailing list