[PATCH] D16324: [ELF][MIPS] Initial support of MIPS local GOT entries

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 05:56:53 PST 2016


> I spent a few hours today to experiment that idea to create SymbolBodies for
> local symbols. Looks like we can do that with a few percent increase in link
> time, and that would make code much more readable. That's a fair trade-off.
> So, I'll take care of this part of code complexity.

I would ask that we avoid doing that, at least for now.

SymbolBody exists for symbol resolution. I find it very counter
intuitive and error prone to create them for things that don't take
part in symbol resolution. I can take some time to try to generalize
local in got handling if you want.

Cheers,
Rafael


More information about the llvm-commits mailing list