[PATCH] D16141: [TableGen] Fix sort order of asm operand classes

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 01:46:07 PST 2016


olista01 added inline comments.

================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:1596
@@ -1542,1 +1595,3 @@
+  }
+#endif
 }
----------------
craig.topper wrote:
> Can we use std::is_sorted here and the location below?
std::is_sorted just checks adjacent elements, and assumes that operator< is well-behaved, so wouldn't have caught this bug before it started causing (windows-only in my case) test failures.


http://reviews.llvm.org/D16141





More information about the llvm-commits mailing list