[PATCH] D16387: [llvm-go] add component lib deps to llvm-go

[Andrew Wilkins via llvm-commits]

axw added a comment.

In http://reviews.llvm.org/D16387#331920, @pcc wrote:

> > For both libLLVMGlobalISel and libLLVMDebugInfoCodeView? The former would be lacking a build rule due it being optional, but was causing llvm-config to complain due to the component not being marked optional. I've fixed that in r258379.
>
>
> Okay, I see.
>
> > I don't think that helps. As far as I can see, that list of components is only used by the standalone Go bindings build (bindings/go/build.sh).
>
>
> It used to be passed to llvm-config by llvm-go.go until your change r258283, and things worked until then. As you are fixing build breakage I would have preferred a more minimal change that reverts things to the way they used to work. But this is fine as well, LGTM.


Oops, so it was. That was an accident. I'll just add components back in there, and forget about this change.


http://reviews.llvm.org/D16387