[PATCH] D16387: [llvm-go] add component lib deps to llvm-go

[Andrew Wilkins via llvm-commits]

axw added a comment.

In http://reviews.llvm.org/D16387#331898, @pcc wrote:

> Does this solve the problem?


With this change, check-llvm-bindings-go works in a clean build.

> In Evgeniy's configuration the libraries llvm-config was looking for wasn't being built (i.e. there were no build rules for them).


For both libLLVMGlobalISel and libLLVMDebugInfoCodeView? The former would be lacking a build rule due it being optional, but was causing llvm-config to complain due to the component not being marked optional. I've fixed that in r258379.

> Can't you just append components on line 92 of llvm-go.go?


I don't think that helps. As far as I can see, that list of components is only used by the standalone Go bindings build (bindings/go/build.sh).

The issue is that the lit tests are using llvm-go, but neither llvm-go nor the test targets currently depend on all of the components that it will use. I could add the dependencies to the test targets, but it seems a bit simpler just to have llvm-go depend on them. It's not much use without them.


http://reviews.llvm.org/D16387