[PATCH] D16356: Color the background of sparklines on the daily report page based on the hash value of the binary.

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 17:07:17 PST 2016


cmatthews requested changes to this revision.
cmatthews added a comment.
This revision now requires changes to proceed.

Mostly looks good.  Could you move the color selection logic out of analysis.py and into lnt/server/ui/util.py?  Analysis seems like a strange place for color selection logic to live.


http://reviews.llvm.org/D16356





More information about the llvm-commits mailing list