[PATCH] D16354: [ELF] - Refactoring of Writer<ELFT>::scanRelocs()

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Writer.cpp:195
@@ -194,1 +194,3 @@
 
+template <class ELFT, bool isRela>
+static bool handleTlsRelocations(unsigned Type, SymbolBody *Body,
----------------
Instead of parameterizing isRela, you can parameterize RelT and change the function signature to bool(unsigned Type, SymbolBody *, InputSectionBase<ELFT> &, RelT &RI)

================
Comment at: ELF/Writer.cpp:196
@@ +195,3 @@
+template <class ELFT, bool isRela>
+static bool handleTlsRelocations(unsigned Type, SymbolBody *Body,
+                                 InputSectionBase<ELFT> &C,
----------------
Relocations -> Relocation because this function handles one relocation at a time.


http://reviews.llvm.org/D16354