[PATCH] D16324: [ELF][MIPS] Initial support of MIPS local GOT entries
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 20 14:42:20 PST 2016
ruiu added a comment.
LGTM assuming that we are not going to keep MipsLocalGotPos indefinitely. We need to simplify this in future.
================
Comment at: ELF/InputSection.cpp:224
@@ +223,3 @@
+ // entries in the local part of MIPS GOT. In that case we need an entry
+ // initialized by full address oif the symbol.
+ SymVA = Out<ELFT>::Got->getMipsLocalFullAddr(*Body);
----------------
Typo: oif
Repository:
rL LLVM
http://reviews.llvm.org/D16324
More information about the llvm-commits
mailing list