[PATCH] D16324: [ELF][MIPS] Initial support of MIPS local GOT entries

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 12:22:48 PST 2016


ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:125
@@ +124,3 @@
+GotSection<ELFT>::getMipsLocalPageAddr(uintX_t EntryValue) {
+  return getMipsLocalEntryAddr((EntryValue + 0x8000) & ~0xffff);
+}
----------------
ruiu wrote:
> atanasyan wrote:
> > ruiu wrote:
> > > What is 0x8000?
> > In fact this is a %hi() expression without right-shifting. Like `mipsHigh` or `applyPPCHa()`.
> Please add a comment to describe that.
Is this done? Maybe you forgot to upload the latest patch?


Repository:
  rL LLVM

http://reviews.llvm.org/D16324





More information about the llvm-commits mailing list