[PATCH] D15644: [asan] Use private aliases for global variables (compiler-rt part).

[Maxim Ostapenko via llvm-commits]

m.ostapenko added inline comments.

================
Comment at: lib/asan/asan_globals.cc:247
@@ +246,3 @@
+    u8 *odr_indicator = reinterpret_cast<u8 *>(g->odr_indicator);
+    *odr_indicator = 0;
+  }
----------------
ygribov wrote:
> What if indicator was set by a different module?
Well, if not consider concurrently running dlopen and dclose, this should never happen, because we have caught ODR violation, that happened before, no? If consider concurrency issues - yes, your nit is totally reasonable. Since original code seems not be thread safe, I didn't implement my changes to be thread safe either. So I wonder, if I should consider races here.


Repository:
  rL LLVM

http://reviews.llvm.org/D15644