[PATCH] D16090: [SelectionDAG] Fold more offsets into GlobalAddresses
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 19 22:48:25 PST 2016
arsenm added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:397
@@ +396,3 @@
+ /// Match "(X shl/srl V1) & V2" where V2 may not be present.
+ bool MatchRotateHalf(SDValue Op, SDValue &Shift, SDValue &Mask);
+
----------------
arsenm wrote:
> I think it would be better to move this to either SelectionDAG (or maybe TLI). It should be generally useful to targets
By this I mean isConstantIntBuildVectorOrConstantInt, not MatchRotateHalf
Repository:
rL LLVM
http://reviews.llvm.org/D16090
More information about the llvm-commits
mailing list