[PATCH] D10725: Improve testing for the C API

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 19:35:44 PST 2016


deadalnix added inline comments.

================
Comment at: tools/llvm-c-test/echo.cpp:44
@@ +43,3 @@
+      return (unsigned((uintptr_t)PtrVal) >> 4) ^
+             (unsigned((uintptr_t)PtrVal) >> 9);
+    }
----------------
joker.eph wrote:
> Why not just reuse hash_value?
> ```
> return hash_value(PtrVal);
> ```
I just based myself on the default implementation for DenseMapInfo, I can use that if you think this is more appropriate.


http://reviews.llvm.org/D10725





More information about the llvm-commits mailing list