[llvm] r258221 - [X86] Do not run shrink-wrapping on function with split-stack attribute or HiPE

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 16:11:22 PST 2016


On Tue, Jan 19, 2016 at 4:06 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>
>> On Jan 19, 2016, at 4:02 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Tue, Jan 19, 2016 at 3:29 PM, Quentin Colombet via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Author: qcolombet
>>> Date: Tue Jan 19 17:29:03 2016
>>> New Revision: 258221
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=258221&view=rev
>>> Log:
>>> [X86] Do not run shrink-wrapping on function with split-stack attribute or HiPE
>>> calling convention.
>>> The implementation of the related callbacks in the x86 backend for such
>>> functions are not ready to deal with a prologue block that is not the entry
>>> block of the function.
>>>
>>> This fixes PR26107, but the longer term solution would be to fix those callbacks.
>>
>> Should this be merged to 3.8?
>
> Yes, along with r258207, otherwise it won’t compile.
>
> Let me know if you want me to do the merge.

Yes, please go ahead and merge with the script in
utils/release/merge.sh. Thanks!


More information about the llvm-commits mailing list