[PATCH] D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source, Result}ElementType.

[Eduard Burtescu via llvm-commits]

eddyb added inline comments.

================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp:516
@@ -515,2 +515,3 @@
     } else {
-      Ty = cast<SequentialType>(Ty)->getElementType();
+      if (Ty->isPointerTy()) {
+        // The only pointer type is for the very first index,
----------------
dblaikie wrote:
> This seems like a slightly indirect test of the property you describe in the comment.
> 
> Do you think it might be nicer to check if the iterator is == I->op_begin() + 1? Or to add a flag of some kind before the loop for this first case? Or perhaps to use a gep type iterator in parallel with the operands? (or an assert for any of these conditions)
> 
> Not necessary, just throwing some ideas around in case any of them seem like an improvement.
I think I would use `gep_type_iterator`, but I would have to rewrite each of these loops (and maybe make `gep_type_iterator` nicer to use, with C++11 range-for sugar perhaps).

Although, now that I've gotten myself set with a fast rebase/rebuild cycle, it shouldn't be such an ordeal anymore, I might just try it out.


Repository:
  rL LLVM

http://reviews.llvm.org/D16275