[llvm] r258210 - Reenable -Wexpansion-to-defined.

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 14:46:33 PST 2016


Author: nico
Date: Tue Jan 19 16:46:33 2016
New Revision: 258210

URL: http://llvm.org/viewvc/llvm-project?rev=258210&view=rev
Log:
Reenable -Wexpansion-to-defined.

I think I fixed all instances of this in the codebase
(r258202, 258200, 258190).  Also, the suppression didn't
have an effect on bots using make anyways, and it looks
like many bots still use configure/make bots.

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=258210&r1=258209&r2=258210&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Tue Jan 19 16:46:33 2016
@@ -403,9 +403,6 @@ elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE
     append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
     append("-Wcast-qual" CMAKE_CXX_FLAGS)
 
-    # FIXME: Clean up the codebase, then remove this flag.
-    add_flag_if_supported("-Wno-expansion-to-defined" EXPANSION_TO_DEFINED_FLAG)
-
     # Turn off missing field initializer warnings for gcc to avoid noise from
     # false positives with empty {}. Turn them on otherwise (they're off by
     # default for clang).




More information about the llvm-commits mailing list