[PATCH] D16156: Proper handling of diamond-like cases in if-conversion

[Matthias Braun via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM, with nitpick addressed.


================
Comment at: lib/CodeGen/IfConversion.cpp:1492-1493
@@ +1491,4 @@
+  if (!BBI2->BB->empty() && (DI2 == BBI2->BB->end())) {
+    auto BBI1T = BBI1->BB->getFirstTerminator();
+    auto BBI2T = BBI2->BB->getFirstTerminator();
+    if ((BBI1T != BBI1->BB->end()) && TII->isPredicated(BBI1T) &&
----------------
I'd prefer an explicit MachineBasicBlock::iterator here instead of auto.


Repository:
  rL LLVM

http://reviews.llvm.org/D16156