[PATCH] D15779: [ELF] - Implemented optimization for R_X86_64_GOTPCREL relocation.

[George Rimar via llvm-commits]

grimar added a comment.

Lots of tests started to crash if I remove the  "Off <= 2" check. I think that was the reason why I added that initially.

25>      lld :: ELF/dynamic-reloc-weak.s
25>      lld :: ELF/got.s
25>      lld :: ELF/gotpc-relax-und-dso.s
25>      lld :: ELF/local-got-shared.s
25>      lld :: ELF/local-got.s
25>      lld :: ELF/relocation.s
25>      lld :: ELF/relro.s

For example ELF/local-got.s which has

  _start:
  	call bar at gotpcrel

So it looks would be better or to leave check as is for now or to add Off argument to RelocateOne.


http://reviews.llvm.org/D15779