[PATCH] D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 10:31:40 PST 2016


> If you are conceptually OK with this fix, I will update MallocSROA-section.ll and do the cosmetic changes Mehdi requested in the next patch.

Sure.

> ================
> Comment at: test/Transforms/GlobalOpt/GSROA-section.ll:6
> @@ +5,3 @@
> +; RUN: opt < %s -globalopt -S | FileCheck %s
> +; Check that the new global values still have their address space
> +; CHECK: @struct
> ----------------
> rafael wrote:
>> You are checking the section, not the address space.
> Yes, this is the intent. Without this patch "struct" uses its original section assignment.

But then the comment is out of sync.


More information about the llvm-commits mailing list