[llvm] r256007 - Recognize strings for Hexagon-specific variant kinds

[Krzysztof Parzyszek via llvm-commits]

On 1/12/2016 10:32 AM, David Blaikie wrote:
>
> Not sure how other targets work, but I imagine we'd usually only add
> things when they're used - that way we can ensure they're tested & no
> one is left wondering about 'dead' code, or lacking tests when they
> become live at some point in the future.
>
> But I know, generally, there are some exceptions where it's
> easier/better to add a few cases in pre-emptively, to ease migration,
> etc. I don't know if this is one of those cases.

I looked at this again---the PCREL kind is actually necessary for all 
the PIC tests we have now:
   test/CodeGen/Hexagon/pic-jumptables.ll
   test/CodeGen/Hexagon/pic-simple.ll
   test/CodeGen/Hexagon/pic-static.ll
Without it the compiler will crash on all of these.

The rest will be needed when I upstream the TLS support, which should 
happen soon---it's just a matter of finding time to do it.  You're 
right---I added these extra strings so that I don't have to modify that 
file multiple times, knowing that they will be needed.  When I add the 
TLS support, I'll make sure that we actually use all of them.

-Krzysztof



-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation