[PATCH] D16072: [X86][SSE] Add INSERTPS target shuffle combines.

[Simon Pilgrim via llvm-commits]

RKSimon added a comment.

Thanks Sanjay, I'll get an updated patch out soon - the consecutive merge loads failures were due to some extra tests I added for http://reviews.llvm.org/D16217.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:23605
@@ +23604,3 @@
+/// not just zeroable.
+static bool ResolveTargetShuffleZeroElts(SDValue N,
+                                         SmallVectorImpl<int> &Mask) {
----------------
spatel wrote:
> "resolveTarget..."
> 
> or if the previous inline comment applies, combine the 2 helper functions and call it "setShuffleMaskZeroElements" ?
I'll merge them - computeKnownZeroShuffleElements was over zealous future proofing on my part.


Repository:
  rL LLVM

http://reviews.llvm.org/D16072