[PATCH] D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

This is probably OK with the nits addressed since it doesn't introduce new optimizations, just makes existing ones a bit less objectionable.


================
Comment at: test/Transforms/GlobalOpt/GSROA-section.ll:6
@@ +5,3 @@
+; RUN: opt < %s -globalopt -S | FileCheck %s
+; Check that the new global values still have their address space
+; CHECK: @struct
----------------
You are checking the section, not the address space.

================
Comment at: test/Transforms/GlobalOpt/MallocSROA-section.ll:10
@@ +9,3 @@
+ at Y = internal global %struct.xyz* null ,section ".foo"            ; <%struct.xyz**> [#uses=2]
+ at numf2s = external global i32                     ; <i32*> [#uses=1]
+
----------------
You can probably clean up this test. You don't need the numf2s global, init_net can just take an argument to store, you don't need the nounwind marker, etc.


http://reviews.llvm.org/D16074