[PATCH] D15784: Enable 2 warnings on MSVC, turn on StringPooling & intrinsic functions

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 05:55:38 PST 2016


aaron.ballman added inline comments.

================
Comment at: C:/LLVM/llvm/cmake/modules/HandleLLVMOptions.cmake:366
@@ -365,1 +365,3 @@
 
+  if(MSVC14)
+    # Disable string literal const->non-const type conversion
----------------
Is this supported in CMake 2.8.8 (that's our min required version of CMake currently)? Also, is this forwards compatible, or will it only enable strictStrings on MSVC 14 and not later versions? (I don't know CMake well enough to answer either of those questions.)


http://reviews.llvm.org/D15784





More information about the llvm-commits mailing list