[PATCH] D16313: [X86][AVX512] fix dag & add intrinsics for fixupimm

[Igor Breger via llvm-commits]

igorb added inline comments.

================
Comment at: E:/Work/LLVM/trunk/lib/Target/X86/X86InstrAVX512.td:7529
@@ +7528,3 @@
+     defm rmi : AVX512_maskable_3src_scalar<opc, MRMSrcMem, _, (outs _.RC:$dst),
+                      (ins _.RC:$src2, _.MemOp:$src3, i32u8imm:$src4),
+                      OpcodeStr##_.Suffix, "$src4, $src3, $src2", "$src2, $src3, $src4",
----------------
why _.MemOp and not _.ScalarMemOp ? If you change it i think you can remove defm rmi_alt 

================
Comment at: E:/Work/LLVM/trunk/test/CodeGen/X86/avx512-intrinsics.ll:7046
@@ +7045,3 @@
+}
+
+
----------------
please remove empty lines.

================
Comment at: E:/Work/LLVM/trunk/test/CodeGen/X86/avx512vl-intrinsics.ll:7708
@@ +7707,3 @@
+  %res = call <2 x double> @llvm.x86.avx512.mask.fixupimm.pd.128(<2 x double> %x0, <2 x double> %x1,<2 x i64> %x2, i32 5, i8 %x4)
+  %res1 = call <2 x double> @llvm.x86.avx512.mask.fixupimm.pd.128(<2 x double> zeroinitializer, <2 x double> %x1, <2 x i64> %x2, i32 4, i8 %x4)
+  %res2 = call <2 x double> @llvm.x86.avx512.mask.fixupimm.pd.128(<2 x double> %x0, <2 x double> %x1, <2 x i64> %x2, i32 3, i8 -1)
----------------
could you please remove zeroinitializer from the tests? It only complicate checks.

================
Comment at: E:/Work/LLVM/trunk/test/CodeGen/X86/avx512vl-intrinsics.ll:7753
@@ +7752,3 @@
+}
+
+
----------------
please remove empty lines


Repository:
  rL LLVM

http://reviews.llvm.org/D16313