[PATCH] D15271: Split functions to create shrink wrapping opportunities

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/Target/PowerPC/PPCEnableShrinkWrap.cpp:35
@@ +34,3 @@
+#include "PPC.h"
+#include "llvm/Transforms/Scalar.h"
+#include "llvm/IR/Function.h"
----------------
Shouldn't this be sorted lower?

================
Comment at: lib/Target/PowerPC/PPCEnableShrinkWrap.cpp:68
@@ +67,3 @@
+
+  static bool branchesTo(TerminatorInst *term, BasicBlock *succ) {
+    for (unsigned i = 0; i < term->getNumSuccessors(); ++i)
----------------
Please follow the LLVM coding standard for naming variables: http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly

================
Comment at: lib/Target/PowerPC/PPCEnableShrinkWrap.cpp:75
@@ +74,3 @@
+
+  static bool canBeComputedWithoutStack(llvm::Value *V) {
+    if (isa<Constant>(V))
----------------
`llvm::` should be unnecessary.


http://reviews.llvm.org/D15271