[PATCH] D16141: [TableGen] Fix sort order of asm operand classes

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 16:15:53 PST 2016


dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.

Thanks for working on this!

FWIW this fix looks right to me, but I'm not sure I've ever committed
to tablegen.  Please track down someone that knows the code better to
chime in.

> +  /// operator< - Compare two classes. This does not produce a total ordering,

>  +  /// but does guarantee that subclasses are sorted before their parents, and

>  +  /// that the ordering is transitive.


Since you're changing the comment anyway, can you update the style
(remove the function name at the start of it)?


Repository:
  rL LLVM

http://reviews.llvm.org/D16141





More information about the llvm-commits mailing list