[PATCH] D16268: Add a new insert_as() method to DenseMap and use it for ConstantUniqueMap

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 13:43:27 PST 2016


dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.

LGTM.  In the DenseMapInfo, it might be cleaner to store the hash
in the LookupKey as an Optional<unsigned> rather than creating a
third type that the DenseMapInfo understands, but I'm not sure.
Either way seems fine.


http://reviews.llvm.org/D16268





More information about the llvm-commits mailing list