[PATCH] D16256: AMDGPU: Reduce 64-bit SRAs

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 12:50:57 PST 2016


tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:2659
@@ +2658,3 @@
+
+  // sra i64:x, 32 -> build_pair x, sra hi_32(x), 31
+  if (RHSVal == 32) {
----------------
This comment is confusing.  I think you need parentheses around the  sra arguments.


http://reviews.llvm.org/D16256





More information about the llvm-commits mailing list