[PATCH] D15779: [ELF] - Implemented optimization for R_X86_64_GOTPCREL relocation.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

Do you also intend to also implement the other optimizations listed in the ABI?


================
Comment at: ELF/Target.cpp:664
@@ +663,3 @@
+    return false;
+  return (!Config->Shared || S.getVisibility() == STV_HIDDEN);
+}
----------------
canBePreempted already checks this, no?

================
Comment at: test/ELF/gotpc-relax-und-dso.s:24
@@ +23,3 @@
+// DISASM:      _start:
+// DISASM-NEXT:     1002: 48 8b 05 97 10 00 00 movq 4247(%rip), %rax
+// DISASM-NEXT:     1009: 48 8b 05 90 10 00 00 movq 4240(%rip), %rax
----------------
Use {{.*}} instead of checking the bits.


http://reviews.llvm.org/D15779