[PATCH] D16294: [AVX512] Adding VPERMB instruction

[Elena Demikhovsky via llvm-commits]

delena added a comment.

Only minor changes, you can fix and commit.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:4196
@@ -4195,1 +4195,3 @@
 
+multiclass avx512_vperm<bits<8> opc, string OpcodeStr,
+                              Predicate pre1,Predicate pre2, SDNode OpNode,
----------------
let's call this class avx512_vperm_bw

================
Comment at: lib/Target/X86/X86InstrAVX512.td:4210
@@ -4196,2 +4209,3 @@
 
-defm VPERM  : avx512_var_shift_w<0x8D, "vpermw", X86VPermv>;
+defm VPERMW  : avx512_vperm<0x8D, "vpermw",HasBWI ,HasVLX , 
+                                  X86VPermv,avx512vl_i16_info>, VEX_W;
----------------
Please put whitespace after each ','.

================
Comment at: lib/Target/X86/X86InstrInfo.td:799
@@ -799,1 +798,3 @@
+def HasVBMI      : Predicate<"Subtarget->hasVBMI()">
+                    ,AssemblerPredicate<"FeatureVBMI", "AVX-512 VBMI ISA">;
 def HasRTM       : Predicate<"Subtarget->hasRTM()">;
----------------
?


http://reviews.llvm.org/D16294