[llvm] r258032 - [Orc] Expand a comment explaining a unit test.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 17:00:19 PST 2016


Author: lhames
Date: Sun Jan 17 19:00:19 2016
New Revision: 258032

URL: http://llvm.org/viewvc/llvm-project?rev=258032&view=rev
Log:
[Orc] Expand a comment explaining a unit test.

Modified:
    llvm/trunk/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp

Modified: llvm/trunk/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp?rev=258032&r1=258031&r2=258032&view=diff
==============================================================================
--- llvm/trunk/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp (original)
+++ llvm/trunk/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp Sun Jan 17 19:00:19 2016
@@ -120,6 +120,11 @@ TEST_F(ObjectLinkingLayerExecutionTest,
   // Module 2:
   //   int bar();
   //   int foo() { return bar(); }
+  //
+  // Verify that the memory manager is only finalized once (for Module 2).
+  // Failure suggests that finalize is being called on the inner RTDyld
+  // instance (for Module 1) which is unsafe, as it will prevent relocation of
+  // Module 2.
 
   ModuleBuilder MB1(getGlobalContext(), "", "dummy");
   {




More information about the llvm-commits mailing list