[PATCH] D16016: [PGO] IR level instrumentation of indirect call value profiling

[David Li via llvm-commits]

davidxl added a comment.

LGTM with the naming nits fixed.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:318
@@ +317,3 @@
+// Visitor class that finds all indirect call sites.
+struct GetIndirectCallVisitor : public InstVisitor<GetIndirectCallVisitor> {
+  std::vector<CallInst *> IndirectCallInsts;
----------------
betulb wrote:
> I do not like the variables to have names like "Get....". IndirectCallSiteVisitor would have been more appropriate.
Maybe 
PGOIndirectCallSiteVisitor.


http://reviews.llvm.org/D16016