[PATCH] D16239: Fix PR25526 by adding back limited cmpxchg pseudo-Insts

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 12:57:23 PST 2016


mcrosier added a comment.

In http://reviews.llvm.org/D16239#328201, @t.p.northover wrote:

> > Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:2360
>
> >  @@ -2325,1 +2359,3 @@
>
> >  +    SelectCMP_SWAP(Node);
>
> >  +    return 0;
>
> > 
>
> >   case ISD::READ_REGISTER:
>
> > 
>
> >  ----------------
>
> > 
>
> > return nullptr;
>
>
> Thanks Chad. Will do, sorry about that. I also realised I'd not
>  updated the comments properly yet. The one in AArch64InstrAtomics.td
>  is misleading and more elsewhere would probably help.


Np.  Wish I could offer more assistance..

Chad


================
Comment at: test/CodeGen/AArch64/cmpxchg-O0.ll:76
@@ +75,1 @@
+}
\ No newline at end of file

----------------
Please add a new line.


http://reviews.llvm.org/D16239





More information about the llvm-commits mailing list