[PATCH] D16196: [test-suite] Add HOME to test env under lit

[Matthias Braun via llvm-commits]

MatzeB added a comment.

In http://reviews.llvm.org/D16196#327265, @mcrosier wrote:

> In http://reviews.llvm.org/D16196#327233, @MatzeB wrote:
>
> > As for the sqlite3 issue: Maybe we should just patch it not check for the home directory and continue anyway. It's always unfortunate if we have to modify the existing benchmarks and it has the risk that the next person putting a newer version of sqlite3 in there will miss the patches. The latter point can be mitigated by documenting the changes in a README-LLVM in the benchmark directory I guess.
>
>
> I'm fine with this solution as well.  Just let me know which direction you'd prefer to take.
>
>   Chad


I shortly looked at the sqlite3 source and if I read it correctly, then it should be enough to checkin an empty sqliterc file and change RUN_OPTIONS TO:

  set(RUN_OPTIONS -init ${CMAKE_CURREN_SOURCE_DIR}/sqliterc :memory:)

and it should not try to read $HOME/.sqliterc anymore. You can do that right now without further review I think.

About the environment variables, I currently prefer the idea of the user specifying a whitelist at configuration time, but we can tackle that in a separate commit.


http://reviews.llvm.org/D16196