[PATCH] D16224: [llvm-readobj] Add support for TLSDESC_PLT and TLSDESC_GOT dynamic section tags to the llvm-readobj.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1341
@@ -1340,1 +1340,3 @@
   LLVM_READOBJ_TYPE_CASE(GNU_HASH);
+  LLVM_READOBJ_TYPE_CASE(TLSDESC_PLT);
+  LLVM_READOBJ_TYPE_CASE(TLSDESC_GOT);
----------------
davide wrote:
> Just put these in the right place (before RELA, that is).
Hmm, I think its in the right place now. I put it in according of their constant values:

  DT_GNU_HASH     = 0x6FFFFEF5, // Reference to the GNU hash table.
  DT_TLSDESC_PLT  = 0x6FFFFEF6, // Location of PLT entry for TLS descriptor resolver calls.
  DT_TLSDESC_GOT  = 0x6FFFFEF7, // Location of GOT entry used by TLS descriptor resolver PLT entry.
  DT_RELACOUNT    = 0x6FFFFFF9, // ELF32_Rela count.
  DT_RELCOUNT     = 0x6FFFFFFA, // ELF32_Rel count.

Isn`t that correct ?


http://reviews.llvm.org/D16224